Replace BEYLA_OTEL_USE_EXPONENTIAL_HISTOGRAMS by standard env var #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
===========================================
- Coverage 78.95% 40.47% -38.48%
===========================================
Files 89 86 -3
Lines 7474 7288 -186
===========================================
- Hits 5901 2950 -2951
- Misses 1252 4164 +2912
+ Partials 321 174 -147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
khushijain21
pushed a commit
to nokia/beyla
that referenced
this pull request
Feb 23, 2024
mariomac
added a commit
that referenced
this pull request
Apr 5, 2024
* test * chart.yaml * service-account * after helm create * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * test chart.yaml * service-account * after helm create adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * adding rbac with changes for labels and annotations Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * Replace BEYLA_OTEL_USE_EXPONENTIAL_HISTOGRAMS by standard environment variable (#635) * Automatic update of offsets.json (#639) Co-authored-by: MattFrick <MattFrick@users.noreply.github.com> * Fix missing go_trace_map cleanup (#638) * add release namespace * Update cluster-role.yaml * Update cluster-role-binding.yaml * values.yaml * configmap and env * secret ref * values.yaml * Update configmap.yaml * Update configmap.yaml * Update values.yaml * Update configmap.yaml * values.yaml * configmap and daemonset changes * 101 * changed existing configmap * clusterolebinding * Update cluster-role-binding.yaml * added comments for external configmap * adding k8s service in helm chart to expose internal beyla metrics. Signed-off-by: Syed Nihal <syed.nihal@nokia.com> * affinity, updatestrategy, tolerations ... * Update values.yaml * Delete deployments/helm/templates/tests/test-connection.yaml * Update values.yaml * Update values.yaml * Delete deployments/helm/templates/NOTES.txt * add readme * remove autoscaling * remove autoscaling * remove ingress, update configmap * remove all ingress changes * addressed review comments Signed-off-by: Syed Nihal <syed.nihal@nokia.com> --------- Signed-off-by: Syed Nihal <syed.nihal@nokia.com> Co-authored-by: Syed Nihal <syed.nihal@nokia.com> Co-authored-by: Mario Macias <mario.macias@grafana.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: MattFrick <MattFrick@users.noreply.github.com> Co-authored-by: Nikola Grcevski <6207777+grcevski@users.noreply.github.com> Co-authored-by: Nihal <38865967+wasim-nihal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before releasing Beyla 1.3, I'm changing this environment variable by the standard OTEL variable, so we avoid having to later support and document two environment variables.