Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Docker instructions #664

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Docs: Update Docker instructions #664

merged 2 commits into from
Mar 5, 2024

Conversation

fridgepoet
Copy link
Member

This PR:

  • corrects the port that should be used in the local browser
  • suggests the removal of a comment about privileged: true

docs/sources/setup/docker.md Outdated Show resolved Hide resolved
docs/sources/setup/docker.md Outdated Show resolved Hide resolved
@fridgepoet fridgepoet marked this pull request as ready for review March 5, 2024 13:39
@@ -59,7 +59,7 @@ docker run --rm \
grafana/beyla:latest
```

Once Beyla is running, open `https://localhost:8443` in your browser, use the app to generate test data, and verify that Beyla prints trace requests to stdout similar to:
After Beyla is running, open `https://localhost:18443` in your browser, use the app to generate test data, and verify that Beyla prints trace requests to stdout similar to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [vale] reported by reviewdog 🐶
[Grafana.Spelling] Did you really mean 'stdout'? For product names, the Grafana dictionary might not know of it yet. You need to add an entry to https://github.com/grafana/writers-toolkit/tree/main/vale/dictionaries/en_US-grafana.wordlist to add a product name to the dictionary. Alternatively, raise an issue) and a maintainer will add it for you. For UI elements, use bold formatting. The spell checker doesn't check words with bold formatting. For paths; configuration; user input; code; class, method, and variable names; statuscodes; and console output, use code formatting. The spell checker doesn't check words with code formatting.

If the rule is incorrect or needs improving, report an issue.

If you have reason to diverge from the style guidance, to skip a rule, refer to Skip rules.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@fridgepoet fridgepoet merged commit 88051da into main Mar 5, 2024
7 of 8 checks passed
@mariomac mariomac deleted the fridgepoet-patch-1 branch March 5, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants