Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App metrics attribute selectors #789

Merged
merged 28 commits into from
May 8, 2024
Merged

App metrics attribute selectors #789

merged 28 commits into from
May 8, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Apr 26, 2024 •
edited
Loading

Refactors the attribute selection feature for network metrics and makes it portable for application-level metrics.

This required some deeper changes in the way we deal with attributes, as there are some differences between Prometheus and OTEL that needed to be handled:

  • All the attributes in prometheus are strings, while in OTEL might be also from other types.
  • In OTEL, some attributes are resource-level, while in Prometheus, all the attributes belong to the metric.

This PR lacks the extensive update of the documentation, which will be done in another PR

@mariomac mariomac added do-not-merge WIP or something that musn't be merged wip labels Apr 26, 2024
@mariomac mariomac removed do-not-merge WIP or something that musn't be merged wip labels Apr 30, 2024
@mariomac mariomac changed the title WIP: Attribute filters Attribute filters Apr 30, 2024
@mariomac mariomac changed the title Attribute filters Attribute selectors Apr 30, 2024
@mariomac mariomac changed the title Attribute selectors App metrics attribute selectors Apr 30, 2024
@mariomac mariomac mentioned this pull request May 6, 2024
Merged
grcevski
grcevski approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm amazed how elegant you made this!!!

@mariomac mariomac merged commit fc8f07d into grafana:main May 8, 2024
8 checks passed
@mariomac mariomac mentioned this pull request May 9, 2024
Closed
@mariomac mariomac deleted the attribute-filters branch May 20, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

@marctc marctc Awaiting requested review from marctc marctc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariomac @grcevski