Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document wildcards in attributes.select #996

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Jul 4, 2024

Document the feature from PRs #991 and #995

@mariomac mariomac added the documentation Improvements or additions to documentation label Jul 4, 2024
@mariomac mariomac requested a review from grafsean July 4, 2024 10:23
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (58de56a) to head (fe745e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   80.75%   80.72%   -0.04%     
==========================================
  Files         134      134              
  Lines       10721    10721              
==========================================
- Hits         8658     8654       -4     
- Misses       1558     1560       +2     
- Partials      505      507       +2     
Flag Coverage Δ
integration-test 56.03% <ø> (-0.12%) ⬇️
k8s-integration-test 59.40% <ø> (-0.11%) ⬇️
oats-test 36.41% <ø> (ø)
unittests 50.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/sources/configure/options.md Show resolved Hide resolved
docs/sources/configure/options.md Outdated Show resolved Hide resolved
docs/sources/configure/options.md Outdated Show resolved Hide resolved
@grafsean grafsean self-requested a review July 9, 2024 09:12
Copy link
Contributor

@grafsean grafsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With discussed changes.

@mariomac mariomac merged commit c1564df into grafana:main Jul 9, 2024
8 checks passed
@mariomac mariomac deleted the doc-wildcards branch July 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants