Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofit=false ignored when set from config.yaml #70

Open
JorundMartinsen opened this issue Apr 7, 2022 · 4 comments · Fixed by #122
Open

autofit=false ignored when set from config.yaml #70

JorundMartinsen opened this issue Apr 7, 2022 · 4 comments · Fixed by #122
Labels
bug Something isn't working no stalebot exempt from stale bot

Comments

@JorundMartinsen
Copy link

When setting autofit=false from config.yaml, it is overridden by env-default=true

@JorundMartinsen
Copy link
Author

Might be related to
ilyakaznacheev/cleanenv#82

@github-actions github-actions bot added the stale label Mar 7, 2023
@briangann briangann added no stalebot exempt from stale bot bug Something isn't working and removed stale labels Mar 7, 2023
@LarsStegman
Copy link
Contributor

LarsStegman commented Aug 6, 2024

@briangann I think this issue is still present. The env vars defaults for booleans override the config file settings.

@wolfman42
Copy link

I can confirm that this issue is still present on Windows with version 1.0.8.
.\grafana-kiosk.windows.amd64.exe -c .\config.yaml

general:
  autofit: false
  kiosk-mode: full
  scale-factor: 1.0

autofit setting from YAML file is ignored and autofit is still true.

Setting the environment variable KIOSK_AUTOFIT to false works, though.
$Env:KIOSK_AUTOFIT="false"

@briangann briangann reopened this Nov 2, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in grafana-kiosk Nov 2, 2024
@briangann
Copy link
Collaborator

will fix this, all of the parameters need to be verified to be working in both modes - flags and configuration files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no stalebot exempt from stale bot
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants