-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update customAllValue parameter type to string in dashboard variable docs #172
Conversation
|
The documentation is generated from schemas in Grafana, so any error should be fixed there, or in Grafonnet veneers which overlay the generated code. |
I noticed that the Grafana schemas do not include the customAllValue parameter, so I made changes in the custom directory. Unfortunately, I am unable to run the
|
I've made a PR back to align this PR with main: https://github.com/isarns/grafonnet/pull/1 |
rebase & generate docs
@Duologic Thanks for that! How about the |
|
I use this version |
Probably need master, that version is old, bleeding edge here 😇 |
The generate process should probably become containerized so we don't have these issues. |
Yep that worked thanks! 😃 |
Mind signing the CLA? |
I will open a new PR without the other account that i pushed with accidentally. |
Opened #189 |
Overview
This PR updates the documentation for dashboard variables to correct the
customAllValue
parameter's type. The parameter was previously documented as a boolean, but it is actually a string. This change aligns the documentation with the Grafana documentation and the expected input type.Changes
customAllValue
parameter type has been corrected frombool
tostring
across the documentation where it is referenced.Impact
This change will help users by providing accurate information about the
customAllValue
parameter type, ensuring that dashboard variables are used effectively and as intended within Grafana dashboards.Please review the changes and merge them if everything is in order.