-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grafana] feat: adds multi-org support to sidecar dashboards #3240
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dragomir Veselinovic <dragomir.veselinovic@cyberlab.rs>
Signed-off-by: Dragomir Veselinovic <dragomir.veselinovic@cyberlab.rs>
Signed-off-by: MH <zanhsieh@gmail.com>
Signed-off-by: MH <zanhsieh@gmail.com> Signed-off-by: MH <zanhsieh@gmail.com>
Hello team, any update on this PR? |
Signed-off-by: MH <zanhsieh@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have that feeling, that the current implementation is too complex for normal end-users.
While the provisioning part looks good, using an annotation like grafana_folder
and require with value like /tmp/dashboards/ops/
into it where ops
stands for orgID 3, it feels not great.
What happens, if /tmp/dashboards/ops2/
is used? An error will be not reported. to end-users.
Too much glue is used here to archive something.
However, I will be not the part, who is blocking this.
Converts
sidecar.dashboards.provider
to a list atsidecar.dashboards.providers
allowing the definition of multipleproviders that can be mappped to orgs as required.
Still supports the singular variant to retain backwards compatibility
and will prepend it to any configured
providers
Results in multi-org support defining providers like the example below which
This then allows dashboard configmaps to be define the annotation
grafana_folder: /tmp/dashboards/ops
instructing the sidecar to put the dashboard in the folder that's been specific in our configuration above.Please, have in mind that you can define your own
folderAnnotation:
We used value
grafana_folder
just as example.We reference to this PR: #2939