Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Allow sc-alert to run both as init and watcher #3255

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jgournet
Copy link

No description provided.

Signed-off-by: jgournet <jgournet@bglcorp.com.au>
@jgournet
Copy link
Author

@zanhsieh : sorry, I re-created a new PR as DCO failed and there were too many conflicts

@zanhsieh
Copy link
Collaborator

zanhsieh commented Aug 2, 2024

@jgournet Can you link the previous PR in this PR description so the maintainers can easily look up / review?

@jgournet
Copy link
Author

jgournet commented Aug 4, 2024

Link to previous (same) PR: #3246

Signed-off-by: Jerome <jgournet@bglcorp.com.au>
@jgournet
Copy link
Author

jgournet commented Aug 5, 2024

@zanhsieh :
the merge was blocked because of a conflict on Chart.yaml version number.
I resolved the merge conflict, but we're back at waiting for all tests - hopefully you can resolve this again ?

thank you

@jkroepke
Copy link
Collaborator

jkroepke commented Aug 5, 2024

@zanhsieh What did you think about the native sidecar feature in Kubernetes where the initContainer stay alive?

https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/

I would appreciate that direction more than this PR.

Signed-off-by: Jerome <jgournet@bglcorp.com.au>
Signed-off-by: Jerome <jgournet@bglcorp.com.au>
@zanhsieh
Copy link
Collaborator

@jkroepke
I would keep backward compatibility by default and leave the users adapts themselves since I don't find helm having any solid way to detect new feature gates enabled in helm.

Used wrong grafana version

Signed-off-by: Jerome <jgournet@bglcorp.com.au>
Signed-off-by: MH <zanhsieh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants