[grafana] fix: don't automount default serviceAccount

[cwrau]

this is best-practice

[jkroepke]

Hi, please create a distinct property for it.

helm-charts/charts/grafana/templates/_pod.tpl

Line 8 in bc8f4a1

automountServiceAccountToken: {{ .Values.automountServiceAccountToken }}

automount default

The default service account should never used. Could you create a serviceAccount for imageRender the same way at it's done at grafana?

[cwrau]

Hi, please create a distinct property for it.

helm-charts/charts/grafana/templates/_pod.tpl

Line 8 in bc8f4a1

automountServiceAccountToken: {{ .Values.automountServiceAccountToken }}

automount default

I was thinking about that, but why? If there is no serviceAccount defined, automount is not needed and default shouldn't be used. So the only situation in which automount even makes sense to be enabled is when a serviceAccount is defined. So why make it configurable just so every user has to touch this field, especially when set to true by default?

Could you create a serviceAccount for imageRender the same way at it's done at grafana?

Now that I think about it, is the imageRenderer even able to use a serviceAccount? Maybe we can remove this whole stuff completely?

[jkroepke]

It also best practice to not reference the default serviceAccount anywhere.
Such stupid scanners may still complain that the default serviceAccount is in used.

[cwrau]

It also best practice to not reference the default serviceAccount anywhere.

Yes, that's why I don't think it's useful to have the automountServiceAccountToken to be configurable 👍

Such stupid scanners may still complain that the default serviceAccount is in used.

True, but they can't really detect the opposite, automountServiceAccountToken is true by default and the used serviceAccount is default by default, so the pod does indeed have, by default, access to the default serviceAccount 😅

[jkroepke]

True, but they can't really detect the opposite,

They complain if the default service account is used. I appreciate that you found that issue and I guess its an good time to introduce a dedicate for the image. It's common practice.

[cwrau]

True, but they can't really detect the opposite,

They complain if the default service account is used. I appreciate that you found that issue and I guess its an good time to introduce a dedicate for the image. It's common practice.

Is the imageRenderer even able to use a serviceAccount? Why create one, if it won't be used?

[jkroepke]

Compliance/Security scanners doesn't follow logical rules as well.

[cwrau]

Compliance/Security scanners doesn't follow logical rules as well.

Ok? What does that have to do with anything? 😅

Do you mean we should create an unused serviceAccount / add a flag to be able to set automountServiceAccountToken even though it makes no sense just because some random tools that don't have anything to do with this aren't good?

[jkroepke]

Yes

[cwrau]

Yes

Donso

[zanhsieh]

@jkroepke Can you review again please?