Improve and export errors in packages #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multimo
approved these changes
Sep 10, 2024
| @@ -12,7 +11,7 @@ import ( | |||
|
|
|||
| func EvaluateInFrame(expression string, input *data.Frame) (any, error) { | |||
| if strings.TrimSpace(expression) == "" { | |||
| return nil, errors.New(strings.TrimSpace(fmt.Sprintf("empty/invalid expression. %s", expression))) | |||
| return nil, ErrEmptySummarizeExpression | |||
There was a problem hiding this comment.
Should you also log the expression in case we need to find out the query or this surfaced elsewhere?
There was a problem hiding this comment.
It should be always just empty string or space as we do a check strings.TrimSpace(expression) == "" . Do you think it would still be valuable, as it is always going to be same/similar thing?
Co-authored-by: Tim Mulqueen <Multimo@users.noreply.github.com>
Co-authored-by: Tim Mulqueen <Multimo@users.noreply.github.com>
Co-authored-by: Tim Mulqueen <Multimo@users.noreply.github.com>
…libs into improve-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exports errors so we can check them in Infinity data source and add error source based on error type. This is same as what we did in c9bd79b