Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create page for k6/browser ElementHandle|Frame|Page|Locator's setChecked methods #1666

Closed
heitortsergent opened this issue Jul 22, 2024 · 3 comments · Fixed by #1696
Closed
Assignees
Labels
Area: browser The browser module

Comments

@heitortsergent
Copy link
Collaborator

Related to #1664.

The docs are missing a page for the setChecked function for the ElementHandle object.

@heitortsergent heitortsergent added the Area: browser The browser module label Jul 22, 2024
@heitortsergent
Copy link
Collaborator Author

@inancgumus @ankur22 we got some feedback that we had a 404 on the ElementHandle page and I think we're just missing a page for one of the functions here. I removed the link for now, would you be able to grab this issue? 🙇

@inancgumus
Copy link
Member

It turns out that we don't publish ElementHandle.setChecked to users (it's not available on the browser module's Javascript API). Instead, we have ElementHandle.check and ElementHandle.uncheck. The difference of setChecked is that it toggles input checkboxes.

Next steps:

  • Publish setChecked to users
  • Update the documentation

@inancgumus
Copy link
Member

inancgumus commented Aug 20, 2024

@heitortsergent This can be closed once the reviewers approve #1696 🎉

We made all the necessary updates in grafana/xk6-browser#1340.

@inancgumus inancgumus changed the title Create page for k6/browser ElementHandle setChecked function Create page for k6/browser ElementHandle|Frame|Page|Locator's setChecked methods Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants