Add xk6-proxy to support dynamic proxy settings #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow changing the HTTP proxy settings in the script
|
|
javaducky
suggested changes
Jun 5, 2023
There was a problem hiding this comment.
Thank you and sorry for the delay in reviewing this.
These changes are fine. However, looking at the referenced project, some minor issues would exclude this project from the registry. Please see registry requirements for more details on requirements.
The following items are missing:
- license
- xk6 topic for the repository
- needs a released version
|
Hi @javaducky, sry for the late. Just here to let you know that the requirements had been fulfilled. |
|
@SYM01 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow changing the HTTP proxy settings in the script.
This extension is used for partially resolve the issue #1045