Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename web vital metrics in docs #1178

Merged

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented May 16, 2023

The browser module has renamed the web vital metrics that it emits. You can find more details on why the change was made here: grafana/xk6-browser#884.

This rename change also needs to be reflected in the docs.

@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1178/merge

It will be deleted automatically in 30 days.

Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@inancgumus
Copy link
Member

inancgumus commented Jun 8, 2023

Please merge this PR to #1208 if it's not for v0.10.0 🙇

@ankur22 ankur22 changed the title Rename web vital metrics Rename web vital metrics in docs Jun 12, 2023
@ankur22 ankur22 changed the base branch from main to update/browser-cloud-updates June 12, 2023 12:00
@ankur22 ankur22 force-pushed the rename/884-rename-web-vital-metrics branch from fca54e1 to 51909cf Compare June 12, 2023 12:14
Renames from webvital_first_input_delay to browser_web_vital_fid.
Rename from webvital_time_to_first_byte to browser_web_vital_ttfb.
Rename from webvital_cumulative_layout_shift to browser_web_vital_cls.
Rename from webvital_first_contentful_paint to browser_web_vital_fcp
@ankur22 ankur22 force-pushed the rename/884-rename-web-vital-metrics branch from 51909cf to 5c4eb7c Compare June 12, 2023 12:20
@ankur22 ankur22 merged commit ed497d2 into update/browser-cloud-updates Jun 12, 2023
@ankur22 ankur22 deleted the rename/884-rename-web-vital-metrics branch June 12, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants