Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robots option to frontmatter and edit the markdown of the "category" guides #1203

Merged
merged 8 commits into from
Jun 22, 2023

Conversation

ppcano
Copy link
Collaborator

@ppcano ppcano commented Jun 7, 2023

  • Add robots metatag to frontmatter
  • Allow editing the content of the categories. The API section supports this option but not on the Guides.

Editing the markdown content of the Test Types category to showcase it does not work yet.

@ppcano ppcano changed the title WIP - Add robots option to frontmatter and allow editing the content of the "category" guides WIP - Add robots option to frontmatter and edit the markdown of the "category" guides Jun 7, 2023
@ppcano ppcano self-assigned this Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1203/merge

It will be deleted automatically in 30 days.

@yasell
Copy link
Contributor

yasell commented Jun 15, 2023

Hi @ppcano!

Added robots metatag to Guides frontmatter and allowed editing the content of the categories. Please review

@yasell
Copy link
Contributor

yasell commented Jun 15, 2023

@ppcano but I need more time to investigate templates issue, see the problems now 🤔

@ppcano
Copy link
Collaborator Author

ppcano commented Jun 15, 2023

caa270d edited the Test types index page.

@ppcano but I need more time to investigate templates issue, see the problems now 🤔

Yes! @yasell, here the two issues I found:

1 - Welcome page is now broken.

Screenshot 2023-06-15 at 18 46 51

2 - For consistency, the parent section option on the sidebar should be like the other sections.

  • non-clickable
  • non-bold style

Screenshot 2023-06-15 at 18 53 10

@yasell
Copy link
Contributor

yasell commented Jun 21, 2023

Hey @ppcano! Fixed the welcome page and updated the parent section option on the sidebar, please review 🙏🏻

@ppcano ppcano changed the title WIP - Add robots option to frontmatter and edit the markdown of the "category" guides Add robots option to frontmatter and edit the markdown of the "category" guides Jun 21, 2023
@ppcano
Copy link
Collaborator Author

ppcano commented Jun 21, 2023

@yasell, the robots metatag seems not to be working.

See https://github.com/grafana/k6-docs/pull/1203/files#diff-bd57cb381d3607fe835978f4d267a4869c5893b10da4a65b9619f3ff7a87b692R4

and

Screenshot 2023-06-21 at 18 39 44

The rest looks good. We can merge it after implementating/fixing this. And I am ok doing that change in another PR if that helps!

@ppcano ppcano merged commit de1a7bc into main Jun 22, 2023
@ppcano ppcano deleted the fix-overwrite-category-guides branch June 22, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants