Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xk6-gcp plugin #1240

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat: add xk6-gcp plugin #1240

merged 2 commits into from
Jul 7, 2023

Conversation

deejiw
Copy link
Contributor

@deejiw deejiw commented Jun 29, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

The referenced extension repository needs some minor changes, given the listing requirements. I've detailed them in deejiw/xk6-gcp#1 .

@deejiw deejiw requested a review from javaducky July 7, 2023 04:30
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@javaducky javaducky merged commit 85ba226 into grafana:main Jul 7, 2023
@deejiw deejiw deleted the patch-1 branch July 8, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants