Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k6 browser v1 migration guide #1292

Merged
merged 25 commits into from
Aug 14, 2023
Merged

k6 browser v1 migration guide #1292

merged 25 commits into from
Aug 14, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Aug 11, 2023 •
edited
Loading

No description provided.

@inancgumus inancgumus added the Area: browser The browser module label Aug 11, 2023
@inancgumus inancgumus self-assigned this Aug 11, 2023
@inancgumus inancgumus changed the base branch from main to update/browser-cloud-updates August 11, 2023 09:26
@inancgumus inancgumus linked an issue Aug 11, 2023 that may be closed by this pull request
Docs: Migration guide for k6 browser v1.0.0 API #1259
Closed
@github-actions
Copy link
Contributor

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/1292/merge

It will be deleted automatically in 30 days.

mdcruz
mdcruz reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! I have a few comments :)

src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
@inancgumus inancgumus force-pushed the add/browser-v1-migration-guide branch 2 times, most recently from 6076054 to a3d6b68 Compare August 11, 2023 11:50
@inancgumus inancgumus force-pushed the add/browser-v1-migration-guide branch from 387b9d0 to a4c2804 Compare August 11, 2023 12:22
@inancgumus inancgumus mentioned this pull request Aug 11, 2023
Merged
15 tasks
mdcruz
mdcruz reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor error and 1 comment :)

ka3de
ka3de reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ka3de ka3de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @inancgumus , it's great! 👏
Just made a few small suggestions.

src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Show resolved Hide resolved
ankur22
ankur22 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @inancgumus! 👏 💪

I've left comments for you to consider. Happy for you take what you think makes sense and leave the suggestions that don't.

src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
src/data/markdown/translated-guides/en/03 Using k6 browser/04 Migrating to k6 v0-46.md Outdated Show resolved Hide resolved
inancgumus and others added 4 commits August 14, 2023 14:59
@inancgumus @ankur22
@ka3de @mdcruz
Improve migration guide explanations
93f0f6a 
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Co-authored-by: ka3de <daniel.jimenez@grafana.com>
Co-authored-by: Marie Cruz <mdcruz@users.noreply.github.com>
@inancgumus @ankur22
Better explain browser and browserTYpe
6826071 
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
@inancgumus
Change migration guide toc order
77d0259
@inancgumus
Reexplain simplified resource management
4b9a503
Base automatically changed from update/browser-cloud-updates to main August 14, 2023 12:12
@inancgumus inancgumus marked this pull request as ready for review August 14, 2023 12:15
mdcruz
mdcruz approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@mdcruz mdcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thank you, @inancgumus! 🚀

ka3de
ka3de approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @inancgumus ! 👏
LGTM.

@inancgumus inancgumus merged commit 376d2af into main Aug 14, 2023
4 checks passed
@inancgumus inancgumus deleted the add/browser-v1-migration-guide branch August 14, 2023 16:24
@heitortsergent heitortsergent mentioned this pull request Aug 14, 2023
Merged
@inancgumus inancgumus mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcruz mdcruz mdcruz approved these changes

@ka3de ka3de ka3de approved these changes

@heitortsergent heitortsergent Awaiting requested review from heitortsergent heitortsergent is a code owner

@ankur22 ankur22 Awaiting requested review from ankur22

Assignees

@inancgumus inancgumus

Labels
Area: browser The browser module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Migration guide for k6 browser v1.0.0 API
4 participants
@inancgumus @ankur22 @ka3de @mdcruz