Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update script example from hybrid performance guide #1653

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Jul 16, 2024

What?

The example in our Hybrid performance with k6 browser guide included a couple of variables that weren't defined, and the example won't work if a user is trying to copy/paste it.

I updated the example so that users can copy/paste the script and run it, and it should work.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

@heitortsergent
Copy link
Collaborator Author

@ankur22 @mdcruz would you mind taking a look at this and see if the changes I made to the example script make sense? 🤓

@heitortsergent heitortsergent self-assigned this Jul 16, 2024
@heitortsergent heitortsergent marked this pull request as ready for review July 19, 2024 19:36
@heitortsergent
Copy link
Collaborator Author

I reviewed this locally and with @tom-miseur, so I'm going to go ahead and merge this. 🤓

@heitortsergent heitortsergent merged commit 421a2ac into main Jul 19, 2024
5 checks passed
@heitortsergent heitortsergent deleted the chore/hybrid-example branch July 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant