Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents that setup timeout accepts only positive values #1720

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Sep 13, 2024

What?

In the upcoming v0.54, the setup timeout option gets the validation and starts to accept only positive (>0s) values.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/k6#3898

@olegbespalov olegbespalov added the Area: OSS Content Improvements or additions to community/oss documentation label Sep 13, 2024
@olegbespalov olegbespalov requested a review from a team September 13, 2024 15:07
@olegbespalov olegbespalov self-assigned this Sep 13, 2024
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team September 13, 2024 15:07
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small edit, otherwise looks good. :shipit:

docs/sources/next/using-k6/k6-options/reference.md Outdated Show resolved Hide resolved
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
@olegbespalov olegbespalov merged commit 87b018f into main Sep 23, 2024
4 checks passed
@olegbespalov olegbespalov deleted the feat/setup-typeout branch September 23, 2024 09:07
@olegbespalov olegbespalov mentioned this pull request Sep 23, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants