Add a page on sleep and wait for browser module #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
add/sleep-wait-browser
branch
4 times, most recently
from
b6e2060
to
6139ac2
Compare
ankur22
force-pushed
the
add/sleep-wait-browser
branch
from
6139ac2
to
6c5e6e1
Compare
inancgumus
approved these changes
Sep 23, 2024
docs/sources/next/using-k6-browser/recommended-practices/_index.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/sleep-and-wait.md
Outdated
Show resolved
Hide resolved
andrewslotin
approved these changes
Sep 24, 2024
docs/sources/next/using-k6-browser/recommended-practices/_index.md
Outdated
Show resolved
Hide resolved
ankur22
force-pushed
the
add/sleep-wait-browser
branch
from
7dd3265
to
0f150a3
Compare
inancgumus
approved these changes
Sep 24, 2024
|
@heitortsergent I'm merging this in, but if you have any suggestions I'll open a new PR to make the changes. |
ankur22
force-pushed
the
add/sleep-wait-browser
branch
from
0f150a3
to
e3e45b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This new page details recommendation on
sleepand the variouswait*functions available to the browser module. The main reason for doing this is to guide users away from working withsleepand instead work with the variouswait*APIs, specifically replacingsleepwithpage.waitForTimeout.Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
Updates: #1719