Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example code of SQSClient #1733

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

paperlefthand
Copy link
Contributor

The return value of listQueues has "urls" property

What?

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

The return value of listQueues has "urls" property
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

@heitortsergent
Copy link
Collaborator

@paperlefthand thanks for opening the PR! This looks right to me, I added @mstoykov as a reviewer to double-check as well. 🙏

Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you 🙇🏻

@paperlefthand
Copy link
Contributor Author

Thanks for your approvals.

@heitortsergent heitortsergent merged commit 9f57bd2 into grafana:main Sep 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants