Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: further guidelines around adding extra scripts and assets #19
docs: further guidelines around adding extra scripts and assets #19
Changes from 2 commits
103eb7c
b1dde38
8e415b7
9876b4e
18b1e4d
36f8331
7bec6ca
4b279a9
9a0d216
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use repetitive numbering and let the renderer auto increment for you which makes it easier to update steps: https://grafana.com/docs/writers-toolkit/write/markdown-guide/#numbered-lists
I'm a bit confused by the example because it doesn't reference the
scripts
field. JSON is very hard to demonstrate in the docs though and you have to be very verbose to help a user: https://grafana.com/docs/writers-toolkit/write/style-guide/write-for-developers/#partial-code-examples so I understand there may not be much you can doThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good point let me flesh this out a little better!