Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden workflows #200

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Harden workflows #200

merged 1 commit into from
Jan 14, 2025

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 14, 2025

  • Pin actions to immutable references
  • Don't persist Git credentials so they can't be used in later steps
  • Don't use a cache during release workflows to avoid cache poisoning

Found using zizmor:

zizmor --persona auditor --quiet "--gh-token=${GITHUB_TOKEN}" *.yml

- Pin actions to immutable references
- Don't persist Git credentials so they can't be used in later steps
- Don't use a cache during release workflows to avoid cache poisoning

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345 Jayclifford345 merged commit f51c9fa into staging Jan 14, 2025
2 checks passed
@Jayclifford345 Jayclifford345 deleted the jdb/2025-01-harden-workflows branch January 14, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants