Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 feat change tag marker from killercoda to interactive #30

Conversation

Jayclifford345
Copy link
Collaborator

Updated the directive markers to INTERACTIVE. This will currently be a breaking change for all docs using old syntax wonder if its worth adding a feature to allow both to work or just get the old pages updated.

I also haven't updated the metadata naming conventions let me know what you both think about this. I am open to making those generic aswell but a lot of the metadata might be killercoda specific.

@Jayclifford345 Jayclifford345 added enhancement New feature or request transformer Issues for docs to killercoda tool labels Jun 26, 2024
@Jayclifford345 Jayclifford345 added this to the Updates to Directives milestone Jun 26, 2024
@Jayclifford345 Jayclifford345 requested a review from jdbaldry as a code owner June 26, 2024 10:56
@Jayclifford345 Jayclifford345 linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link
Member

@jdbaldry jdbaldry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so LGTM!

If something breaks, then I'm responsible because of the Beyoncé rule: If you liked it, then you shoulda put a test on it

@Jayclifford345
Copy link
Collaborator Author

hahahahahahahah

@Jayclifford345 Jayclifford345 merged commit 7047ded into staging Jun 26, 2024
2 checks passed
@Jayclifford345 Jayclifford345 deleted the 24-feat-change-tag-marker-from-killercoda-to-interactive branch June 26, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request transformer Issues for docs to killercoda tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Change tag marker from "Killercoda" to "Interactive"
2 participants