Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use page directive instead of specific individual directives for intro, finish, and intermediate steps #41

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

jdbaldry
Copy link
Member

This is a breaking change to behavior and replaces the separate finish, intro, and step directives.

I decided to go with the name page to distinguish it from assets or resources if we do that in the future.

Signed-off-by: Jack Baldry jack.baldry@grafana.com

jdbaldry added 3 commits June 27, 2024 14:27
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested a review from Jayclifford345 as a code owner June 27, 2024 14:13
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry force-pushed the jdb/2024-06-file-directive branch from 58a2c9a to da9b1c4 Compare June 27, 2024 14:15
@jdbaldry jdbaldry changed the title Use file directive instead of specific individual directives for intro, finish, and intermediate steps Use page directive instead of specific individual directives for intro, finish, and intermediate steps Jun 27, 2024
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested and works great! I will stick up a PR later with an updated example in the examples folder.

"I was here!" ~ Beyonce

@jdbaldry jdbaldry merged commit 1561878 into staging Jun 27, 2024
2 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-06-file-directive branch June 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants