Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace docs/ignore transformer with regexp replacement #53

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Replace docs/ignore transformer with regexp replacement #53

merged 3 commits into from
Jul 4, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jul 3, 2024

Until I better understand how to manipulate the AST, this seems to work.

@jdbaldry jdbaldry requested a review from Jayclifford345 July 3, 2024 15:17
jdbaldry added 3 commits July 4, 2024 11:03
@jdbaldry
Replace docs/ignore transformer with regexp replacement
70f3ad6 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Refactor to use Goldmark Extenders
d8274cd 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry
Refactor raw Markdown processing into Preprocessor interface
b393861 
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry force-pushed the jdb/2024-07-fix-docs/ignore-bug branch from 8b1ae85 to b393861 Compare July 4, 2024 10:04
Jayclifford345
Jayclifford345 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working with:

{{< docs/ignore >}}
### Back to Docs
Head back to wear you started from to continue with the Loki documentation: [Loki documentation](https://grafana.com/docs/loki/latest/send-data/alloy)
{{< /docs/ignore >}}

@jdbaldry jdbaldry merged commit 0af9c4a into staging Jul 4, 2024
2 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-07-fix-docs/ignore-bug branch July 4, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jayclifford345 Jayclifford345 Jayclifford345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdbaldry @Jayclifford345