Add SessionIndex to LogoutRequest if it's available #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihai
approved these changes
Sep 17, 2024
linoman
approved these changes
Sep 17, 2024
Comment on lines
+1213
to
+1215
| if sessionIndex != "" { | ||
| req.SessionIndex = &SessionIndex{sessionIndex} | ||
| } |
There was a problem hiding this comment.
Can we get rid of the conditional statement? Can we get the same results if req.SessionIndex is nil vs ""?
Suggested change
| if sessionIndex != "" { | |
| req.SessionIndex = &SessionIndex{sessionIndex} | |
| } | |
| req.SessionIndex = &SessionIndex{sessionIndex} |
There was a problem hiding this comment.
I enclosed it in the if statement, because req.SessionIndex is a pointer and if that's nil then the xml marshaller skips the field. If I would instantiate SessionIndex regardless of the sessionIndex value then the SessionIndex would be marshalled to xml with an empty value in case of empty sessionIndex and that would change the current behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SessionIndex to LogoutRequest if it's available.