-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket support for search streaming #2971
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving doc changes. Thank you for adding docs.
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty gtm. Still reviewing and hope to test it out locally.
Signed-off-by: Joe Elliott <number101010@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
ps: I didn't test it localy, I am trusting @mdisibio to do it :)
Signed-off-by: Joe Elliott <number101010@gmail.com>
Testing this locally and looking great. However noticed a small issue with the closure error handling. Debugging shows that Tempo is finishing the query successfully and closing the connection from the server-side on line 210 However then the deferred reader to detect unexpected client closure is tripping. Instead of getting Reproduced with both:
|
Signed-off-by: Joe Elliott <number101010@gmail.com>
Good catch. Not sure how I missed this. I feel like the cleanest solution is just to store a bool on the server side that records whether or not we've attempted a closure on the connection. I don't think the error produced can be tested directly to determine if it was graceful or unexpected: 2d4206c |
What this PR does:
Adds websocket support for streaming and deprecates the GRPC endpoint. Due to the issues we've seen with sharing GRPC and HTTP on the same port (which Grafana requires) we believe this is a better path for streaming data. The way this is currently implemented Tempo will close the websocket after it has completed the query and ignore all messages from the client except for normal closure (1000).
Other changes:
Which issue(s) this PR fixes:
Fixes #2917
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]