Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Use glossary lookups instead of duplicating that information #3061

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

jdbaldry
Copy link
Member

No description provided.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@knylander-grafana knylander-grafana self-assigned this Oct 24, 2023
@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Oct 24, 2023
@knylander-grafana knylander-grafana changed the title Use glossary lookups instead of duplicating that information [DOC] Use glossary lookups instead of duplicating that information Oct 24, 2023
@knylander-grafana
Copy link
Contributor

checking this out to test it

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, Jack. This is really cool! The definitions built and show up correct.

@knylander-grafana
Copy link
Contributor

@jdbaldry I updated the glossary.yaml file with a new definition for traces. See https://github.com/grafana/website/pull/16108. This update includes content from #3060

@jdbaldry jdbaldry merged commit 6cb39f9 into knylander-grafana-patch-1 Oct 25, 2023
@jdbaldry jdbaldry deleted the jdb/2023-10-glossary-lookups branch October 25, 2023 08:35
knylander-grafana added a commit that referenced this pull request Nov 17, 2023
* Update definition for traces

* [DOC] Use glossary lookups instead of duplicating that information  (#3061)

* Use glossary lookups instead of duplicating that information

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Fix `make-docs` script typo

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
* Update definition for traces

* [DOC] Use glossary lookups instead of duplicating that information  (#3061)

* Use glossary lookups instead of duplicating that information

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Fix `make-docs` script typo

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 44761ce)
knylander-grafana added a commit that referenced this pull request Nov 22, 2023
* Update definition for traces

* [DOC] Use glossary lookups instead of duplicating that information  (#3061)

* Use glossary lookups instead of duplicating that information

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* Fix `make-docs` script typo

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Jack Baldry <jack.baldry@grafana.com>
(cherry picked from commit 44761ce)

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants