[release-v2.3] Set GRAFANA_VERSION used throughout shared lookups #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
It was working in "next" because the fallback behavior is to use the page's version for any "SOMETHING_VERSION" lookup. Therefore, the `docs/shared` lookup coincidentally targeted "next" which exists in the Grafana documentation. Now that we have cut a new release with these docs, the released version is being used which is causing errors because `v2.3.x` is not a valid Grafana version. Signed-off-by: Jack Baldry <jack.baldry@grafana.com> (cherry picked from commit 32014d7)
github-actions
bot
added
backport
type/docs
github-actions
bot
requested review from
jdbaldry,
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
jdbaldry
approved these changes
Nov 1, 2023
|
@grafana/tempo I find that a significant number of PRs require an empty commit to kickstart CI. Has anyone else noticed this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 32014d7 from #3091
It was working in "next" because the fallback behavior is to use the page's version for any "SOMETHING_VERSION" lookup.
Therefore, the
docs/sharedlookup coincidentally targeted "next" which exists in the Grafana documentation.Now that we have cut a new release with these docs, the released version is being used which is causing errors because
v2.3.xis not a valid Grafana version.Signed-off-by: Jack Baldry jack.baldry@grafana.com