tools: update go and add goyacc and drone-cli #3979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
commented
Aug 21, 2024
build/tools.mk
Outdated
| @@ -12,7 +12,7 @@ TOOL_DIR ?= tools | |||
| TOOL_CONFIG ?= $(TOOL_DIR)/tools.go | |||
|
|
|||
| TOOLS_IMAGE ?= grafana/tempo-ci-tools | |||
| TOOLS_IMAGE_TAG ?= main-5e4eafd | |||
| TOOLS_IMAGE_TAG ?= latest | |||
There was a problem hiding this comment.
Suggested change
| TOOLS_IMAGE_TAG ?= latest | |
| TOOLS_IMAGE_TAG ?= main-5e4eafd |
electron0zero
force-pushed
the
tools_update
branch
from
2b89a92 to
37793c9
Compare
|
This PR has been automatically marked as stale because it has not had any activity in the past 60 days. |
electron0zero
added
keepalive
electron0zero
force-pushed
the
tools_update
branch
from
37793c9 to
7d0ac54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
update tools image to include goyaac and drone-cli,
also update go to 1.23 in the tools image, required to update go version in tempo.
once we have new image with these tools, we can stop using loki-build-image and move these commands to use our own build image.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]