Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I believe these are the changes needed to migrate the backend read path to RF1. New config options
rf1_after
which is a timestamp, after that only blocks with rf==1 are included in searches and trace by ID lookups. And an option to discontinue flushes to object storage from the ingesters.How each api is handled:
Search: the frontend determines the blocks:
Trace lookup: the querier determines the blocks:
Tags: this is actually not filtering on replication factor, so no changes needed
Metrics: already limited to rf1 blocks
The migration path:
rf1_after
to move the read path over to the new RF1 blocks (recent searches/tags/tracelookups are still directed at ingesters)Note: Global config is non-trivial due to Tempo's modular setup, so this adds redundant config in multiple places. Not ideal.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]