Replace cespare/xxhash with cespare/xxhash/v2
#4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
Juneezee
force-pushed
the
refactor/xxhash
branch
from
c815f0b to
7e423db
Compare
`github.com/cespare/xxhash/v2` is the latest version with bug fixes and improvements. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Juneezee
force-pushed
the
refactor/xxhash
branch
from
7e423db to
52b81cd
Compare
|
Rebased to fix conflicts in |
electron0zero
approved these changes
Dec 24, 2024
|
thank you for your contribution 👏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, we are using two versions of the same package for xxHash:
tempo/go.mod
Lines 10 to 11 in dbd7505
github.com/cespare/xxhash/v2is the latest version, which includes bug fixes and improvements. This PR updates the codebase to replacegithub.com/cespare/xxhashwithgithub.com/cespare/xxhash/v2.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]