Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Tests: Use OpenAPI client to check if they exist #1136

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

julienduchesne
Copy link
Member

Gets rid of the manually written checkers
Also, added two common code functions to shorten each helper. We can now define a "checker" in 7 lines. This is definitely an improvement from the 30-50 lines of manually written code :)

Gets rid of the manually written checkers
Also, added two common code functions to shorten each helper. We can now define a "checker" in 7 lines. This is definitely an improvement from the 30-50 lines of manually written code :)
Copy link

github-actions bot commented Nov 8, 2023

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne marked this pull request as ready for review November 8, 2023 03:06
@julienduchesne julienduchesne requested a review from a team as a code owner November 8, 2023 03:06
Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@julienduchesne julienduchesne merged commit 872533d into master Nov 8, 2023
22 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/user-check-exists branch November 8, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants