Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable oncall client setup using service account auth #1958

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Dec 16, 2024

Related to #1953

Updated OnCall API client to allow empty string tokens on setup (see grafana/amixr-api-go-client#27).

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@matiasb matiasb force-pushed the matiasb/oncall-service-account-support-take-2 branch from bf5627a to 7001100 Compare December 16, 2024 13:21
@matiasb matiasb force-pushed the matiasb/oncall-service-account-support-take-2 branch from 7001100 to 6391402 Compare December 16, 2024 15:25
@matiasb matiasb marked this pull request as ready for review December 16, 2024 15:45
@matiasb matiasb requested a review from a team as a code owner December 16, 2024 15:45
// Step 1: Configure provider block.
provider "grafana" {
alias = "oncall"
url = "http://grafana.example.com/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, so we no longer need to make the Terraform provider "aware" of the OnCall API url?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but there was always a default value for it (prod-us-central-0), so you can omit setting it in some cases (see existing docs). It would be great not to need this URL, but there isn't an easy way to figure it out atm (afaict).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great not to need this URL, but there isn't an easy way to figure it out atm

In hosted grafana land we could maybe call the GCOM region API to fetch your stack's oncall regional API url? but yeah this won't support OSS

@matiasb matiasb merged commit 7dc443a into main Dec 17, 2024
26 checks passed
@matiasb matiasb deleted the matiasb/oncall-service-account-support-take-2 branch December 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants