Merge pull request #33 from LaughDonor/master

Allow Query Filter values of null, undefined, or NaN
grahamearley · Jun 27, 2018 · f3978b7 · f3978b7
2 parents b98bd97 + 93b95c2
commit f3978b7
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/Query.js b/Query.js
@@ -46,11 +46,17 @@ var FirestoreQuery_ = function (from, callback) {
   const filter = function (field, operator, value) {
     // @see {@link https://firebase.google.com/docs/firestore/reference/rest/v1beta1/StructuredQuery#FieldFilter Field Filter}
     if (operator in fieldOps) {
-      return {
-        fieldFilter: {
-          field: fieldRef(field),
-          op: fieldOps[operator],
-          value: wrapValue_(value)
+      if (value == null) { // Covers null and undefined values
+        operator = 'null'
+      } else if (isNaN(value)) { // Covers NaN
+        operator = 'nan'
+      } else {
+        return {
+          fieldFilter: {
+            field: fieldRef(field),
+            op: fieldOps[operator],
+            value: wrapValue_(value)
+          }
         }
       }
     }