-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): Introduce warning if non-void expression value not used or ignored #2141
base: main
Are you sure you want to change the base?
Conversation
Let's land this in the next breaking so users aren't surprised by the warnings. |
@alex-snezhko can you rebase this? Looks like the tests are failing on merge because of the LSP tests. |
d6a6fd5
to
dff6f7b
Compare
@ospencer rebased and fixed tests |
@alex-snezhko looks like tests are failing because of formatting. |
dff6f7b
to
b55bd41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, I like getting these warnings
The below code will now give a warning