feat(stdlib): Add isFinite, isClose, sin, cos, tan to Float32
#2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
ospencer,
phated,
peblair,
marcusroberts,
jozanza and
alex-snezhko
as code owners
ospencer
approved these changes
Oct 7, 2024
ospencer
changed the title
isFinite, isClose, sin, cos, tanisFinite, isClose, sin, cos, tan to Float32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds
isFinite,isClose,sin,cosandtanto the float32 library. Originally it was just going to add the trig functions, butisCloseandisFiniteare dependencies for testing the trig functions, I can seperate them into a seperate pr if desired but i did not see any major benefit.This pr also opened the issue: #2167 as it would make sense to use a float32 optimized set of trig functions in the future for better relative accuracy, Float32.pi != Float64.pi will cause the precision to drift with larger values of x.
work towards: #1813