Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib)!: Add an
Ascii
submodule toChar
and moveisAscii
,toUppercase
,toLowercase
#2178base: main
Are you sure you want to change the base?
feat(stdlib)!: Add an
Ascii
submodule toChar
and moveisAscii
,toUppercase
,toLowercase
#2178Changes from 2 commits
2ce457d
466913c
efc1b43
09475de
e9242a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to do the examples as just
Ascii.
without the leadingChar.
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep the
Char.Ascii.isAscii
, I feel like it's not very long and it makes the examples runnable, in other modules such as array I was using the pattern:but I felt that the module name ascii was small enough here to just directly inline it. I think there is real value in having our examples be as runnable as possible while still being small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be chars? If someone really needs the code then they can do a
Char.code
on it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently use the code on the top level module
Char.min
. I think if we really want to change that we should do it in a seperate pr after this. Though there is the argument here thatmin
andmax
are odd values for chars whereas they make more sense in relation to charCodes. maybe we have bothminCode
,maxCode
andmin
,max
?