-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pluggables for puzzle checker #120
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
""" | ||
******************************************************************************** | ||
solvers | ||
******************************************************************************** | ||
|
||
.. currentmodule:: compas_timber.solvers | ||
|
||
.. rst-class:: lead | ||
|
||
This module contains pluggable functions for the sequence generating puzzle checker extensions. | ||
|
||
Pluggables | ||
========== | ||
.. autosummary:: | ||
:toctree: generated/ | ||
:nosignatures: | ||
|
||
next_removable_part | ||
create_dissassembly_sequence | ||
|
||
""" | ||
from compas.plugins import pluggable | ||
from compas.plugins import PluginNotInstalledError | ||
|
||
|
||
@pluggable(category="solvers") | ||
def next_removable_part(assembly, removed_part_ids, part_ids_to_remove, number_of_parts_to_remove, **kwargs): | ||
"""Returns the next part to remove from the assembly. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it be practical to mention what tool does this pluggable attends to? |
||
|
||
One or more parts of the assembly are choosen to be removed next based on the particular solver implementation. | ||
|
||
Parameters | ||
---------- | ||
assembly : `compas.datastructures.Assembly` | ||
The assembly to remove parts from. | ||
removed_part_ids : list | ||
The list of part ids that have already been removed. | ||
part_ids_to_remove : list | ||
The list of part ids that are to be removed. | ||
number_of_parts_to_remove : int | ||
The number of parts to remove from the assembly. | ||
|
||
Returns | ||
------- | ||
:class:`compas_monosashi.sequencer.Step` | ||
A step which contains one or more Instructions which specify | ||
the parts to remove from the assembly and the corresponding removal direction. | ||
|
||
""" | ||
raise PluginNotInstalledError | ||
|
||
|
||
@pluggable(category="solvers") | ||
def create_dissassembly_sequence(assembly, **kwargs): | ||
"""Returns a sequence of steps to disassemble the assembly. | ||
|
||
This function's implementation decides on the strategy used to generate the collection of | ||
steps to disassemble the assembly and determines their order. | ||
|
||
The order of steps can be revered in order to generate a sequence of steps to assemble the assembly. | ||
|
||
Parameters | ||
---------- | ||
assembly : `compas.datastructures.Assembly` | ||
The assembly to disassemble. | ||
|
||
Returns | ||
------- | ||
:class:`compas_monosashi.sequencer.BuildingPlan` | ||
A sequence of steps to disassemble the assembly. | ||
|
||
See Also | ||
-------- | ||
:func:`~compas_timber.solvers.next_removable_part` | ||
|
||
""" | ||
raise PluginNotInstalledError |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a side thought: is there a way to put all these definitions of the pluggables in seperate files? They are all quite specific and I guess the
__init__
file can get quite messy soon.