-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compas main #121
Compas main #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes serialize that asssembly data!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chen! I loked over the changes and mostly get what you are doing. You are right it is a good educaitonal opportunity.
Maybe let me know if or when I should update my COMPAS or CT to use the new serialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
this got me thinking we should probably already bump the version in COMPAS, so that other dependencies such as this one can declare it properly, because now it's somewhat inconsistent, this version only works with compas@main
but it's nowhere visible
@@ -16,7 +16,7 @@ pydocstyle | |||
pytest >=3.2 | |||
pytest-mock | |||
sphinx_compas_theme >=0.13 | |||
sphinx >=3.4 | |||
sphinx ==7.1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required? higher version of sphinx break the theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 7.2.4
breaks the template, I opened compas-dev/sphinx_compas_theme#20.
Also Sphinx are seemingly dropping python versions like flies. 7.2.0
already doesn't support python 3.8 anymore..
Yes this all feels very sketchy and fragile. Anyways we can't add it to |
yes, i don't know what's the best option for doing this, cut a 2.0-alpha release of COMPAS and use that? |
I'd be all in for that. I feel like we shouldn't be too far from 2.0 anyways. @tomvanmele what do you say? |
Updated the
Data
interface inBeam
andAssembly
to comply with the changes in COMPAS core intended to be released in version 2.0.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.