Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH_UI_overhaul #169

Merged
merged 34 commits into from
Jan 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
ec1ea89
added reference surface from beam face
obucklin Jan 5, 2024
e8aacf1
added_jointsByTopo
obucklin Jan 12, 2024
6c440bc
added Info to jointByTopo
obucklin Jan 12, 2024
2cb06a2
Added_jointsFromTopology
obucklin Jan 12, 2024
544ee74
updated changelog
obucklin Jan 12, 2024
0c24bac
Added JointOptions topoJointRule and DirectJoint
obucklin Jan 17, 2024
a1a921b
added some documentaiton
obucklin Jan 17, 2024
5bedbe4
updated changelog
obucklin Jan 17, 2024
769a53b
formatted and de-linted
obucklin Jan 17, 2024
2117782
added cut_plane_bias to x-halfLap
obucklin Jan 17, 2024
5a08aaf
removed old joint defs
obucklin Jan 17, 2024
4bba990
eliminated_autoJoints
obucklin Jan 18, 2024
e177306
added new UI example files
obucklin Jan 18, 2024
1a0b0bf
changed component label
obucklin Jan 18, 2024
2f1cba8
linted and formatted
obucklin Jan 19, 2024
524c79b
weekend!
obucklin Jan 19, 2024
d23f5e7
resolving comments
obucklin Jan 22, 2024
e6bcdd2
Hopefully addressed all comments
obucklin Jan 22, 2024
a2eb0ad
Merge branch 'main' into compas_fab_test1
chenkasirer Jan 23, 2024
7f7e429
removed old XHalfLap component
chenkasirer Jan 23, 2024
ff797ed
updated example file with new GH components
chenkasirer Jan 23, 2024
12d78ea
fixed halflap data interface
chenkasirer Jan 23, 2024
c1a4815
added unittests
chenkasirer Jan 23, 2024
ab12e89
added missing member to french ridge lap
chenkasirer Jan 23, 2024
cf27c52
changed beam face sorting
obucklin Jan 23, 2024
06c1dda
Merge branch 'compas_fab_test1' of https://github.com/gramaziokohler/…
obucklin Jan 23, 2024
2941ef7
fixed some docstrings
chenkasirer Jan 23, 2024
2858b03
added unittests for xhalflap and frenchridge
chenkasirer Jan 23, 2024
5a0a602
Merge branch 'compas_fab_test1' of https://github.com/gramaziokohler/…
chenkasirer Jan 23, 2024
2a6d955
removed unused variable
chenkasirer Jan 23, 2024
3d156ec
added unittests
chenkasirer Jan 23, 2024
80d2bfa
linting
chenkasirer Jan 23, 2024
37e9ae8
removed french ridge unittest as not yet implemented
chenkasirer Jan 23, 2024
ce2e24d
removed unused import
chenkasirer Jan 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/compas_timber/fabrication/btlx.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,14 @@ def __init__(self, beam):
self.processings = []
self._et_element = None


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to many spaces around method, run invoke format

def reference_surface_from_beam_face(self, beam_face):
""" Finds the reference surface with normal that matches the normal of the beam face argument"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameters and Returns missing in docstring

for key, face in self.reference_surfaces.items():
if face.normal == beam_face.normal:
return key


def reference_surface_planes(self, index):
"""Returns the reference surface planes for a given index per BTLx docs."""
if len(self._reference_surfaces) != 6:
Expand Down