-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH_UI_overhaul #169
Merged
Merged
GH_UI_overhaul #169
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
ec1ea89
added reference surface from beam face
obucklin e8aacf1
added_jointsByTopo
obucklin 6c440bc
added Info to jointByTopo
obucklin 2cb06a2
Added_jointsFromTopology
obucklin 544ee74
updated changelog
obucklin 0c24bac
Added JointOptions topoJointRule and DirectJoint
obucklin a1a921b
added some documentaiton
obucklin 5bedbe4
updated changelog
obucklin 769a53b
formatted and de-linted
obucklin 2117782
added cut_plane_bias to x-halfLap
obucklin 5a08aaf
removed old joint defs
obucklin 4bba990
eliminated_autoJoints
obucklin e177306
added new UI example files
obucklin 1a0b0bf
changed component label
obucklin 2f1cba8
linted and formatted
obucklin 524c79b
weekend!
obucklin d23f5e7
resolving comments
obucklin e6bcdd2
Hopefully addressed all comments
obucklin a2eb0ad
Merge branch 'main' into compas_fab_test1
chenkasirer 7f7e429
removed old XHalfLap component
chenkasirer ff797ed
updated example file with new GH components
chenkasirer 12d78ea
fixed halflap data interface
chenkasirer c1a4815
added unittests
chenkasirer ab12e89
added missing member to french ridge lap
chenkasirer cf27c52
changed beam face sorting
obucklin 06c1dda
Merge branch 'compas_fab_test1' of https://github.com/gramaziokohler/…
obucklin 2941ef7
fixed some docstrings
chenkasirer 2858b03
added unittests for xhalflap and frenchridge
chenkasirer 5a0a602
Merge branch 'compas_fab_test1' of https://github.com/gramaziokohler/…
chenkasirer 2a6d955
removed unused variable
chenkasirer 3d156ec
added unittests
chenkasirer 80d2bfa
linting
chenkasirer 37e9ae8
removed french ridge unittest as not yet implemented
chenkasirer ce2e24d
removed unused import
chenkasirer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -167,6 +167,14 @@ def __init__(self, beam): | |
self.processings = [] | ||
self._et_element = None | ||
|
||
|
||
def reference_surface_from_beam_face(self, beam_face): | ||
""" Finds the reference surface with normal that matches the normal of the beam face argument""" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
for key, face in self.reference_surfaces.items(): | ||
if face.normal == beam_face.normal: | ||
return key | ||
|
||
|
||
def reference_surface_planes(self, index): | ||
"""Returns the reference surface planes for a given index per BTLx docs.""" | ||
if len(self._reference_surfaces) != 6: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to many spaces around method, run
invoke format