Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature debug #175

Merged
merged 22 commits into from
Jan 29, 2024
Merged

Feature debug #175

merged 22 commits into from
Jan 29, 2024

Conversation

chenkasirer
Copy link
Contributor

@chenkasirer chenkasirer commented Jan 19, 2024

Fixes #176

  • Feature application now fails more gracefully. The last valid geometry is returned.
  • Joint.add_features implementation raise BeamJoiningError when they fail to support joining of a pair of beams.
  • Assembly component fills in a DebugInformation object with joining and feature errors.
  • Two new components allow visually inspecting the different errors.

image

image

image

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)


Geometry = None
scene = Scene()
debug_scene = Scene() # to collect debug related information

if CreateGeometry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taking with fabio and jonas, we said we wanted to show the beams without features from the assembly component when there are no joint inputs or when CreateGeometry is False. I implemented this in my latest PR. I dont think it should cause any probelms.

@chenkasirer chenkasirer marked this pull request as draft January 25, 2024 10:53
@chenkasirer chenkasirer marked this pull request as ready for review January 28, 2024 15:27
@chenkasirer chenkasirer merged commit 55f2777 into main Jan 29, 2024
11 checks passed
@chenkasirer chenkasirer deleted the feature_debug branch January 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make feature error fail more gracefully
2 participants