T and L-Lap joints and Show_topology_GH_component

[obucklin]

Added ShowTopologyTypes GH component
Added L-Butt Joint including GH Component
Added T-Butt Joint including GH Component

added topologies attribute to TimberAssembly to avoid recalculation

What type of change is this?

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke lint).
• I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[chenkasirer]

@obucklin please merge latest main onto this branch as this still shows changes from already merged PR

[obucklin]

done

…

On Thu, Jan 25, 2024 at 11:56 AM Chen Kasirer ***@***.***> wrote: @obucklin <https://github.com/obucklin> please merge latest main onto this branch as this still shows changes from already merged PR — Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANHAUGQQRG5HSXVBNX4LY3LYQI26BAVCNFSM6AAAAABCFUWGOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHEYTKOBRGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[chenkasirer]

done
…
On Thu, Jan 25, 2024 at 11:56 AM Chen Kasirer @.> wrote: @obucklin https://github.com/obucklin please merge latest main onto this branch as this still shows changes from already merged PR — Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANHAUGQQRG5HSXVBNX4LY3LYQI26BAVCNFSM6AAAAABCFUWGOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHEYTKOBRGQ . You are receiving this because you were mentioned.Message ID: @.>

Thanks, will review by end of today.

[chenkasirer]

Left a bunch of comments here and there.
But two larger topics:

1. There's a ton of duplicate code in the different lap joint implementations, I feel like we could have a single parent class (e.g. LapJoint) where a lot of these functions live and then each concrete implementation would just add or parameterize what's special for it.

1.5 we should start writing unittests for the individual joints. Creating the features involves having to deal with many different cases and we should try to programmatically verify they are covered.

2. the Assembly component is getting kind of big and messy and we should keep an eye on it and potentially upstream some stuff there to the library - but it would be better if we planned this together so lets not deal with it in this PR.

[chenkasirer]

LGTM