Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/t-step joint #251

Closed
wants to merge 21 commits into from
Closed

Feature/t-step joint #251

wants to merge 21 commits into from

Conversation

jonashaldemann
Copy link
Contributor

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@jonashaldemann
Copy link
Contributor Author

@chenkasirer maybe there is some simplification potential in the code where I added a TODO comment...

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I took so long. Looks nice! I made a first pass of comments. Let me know if there's anything that's not clear.

src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
src/compas_timber/connections/t_step.py Outdated Show resolved Hide resolved
@jonashaldemann
Copy link
Contributor Author

feedback from Chen & cross beam extension added, ready for a last review & merge?

@jonashaldemann
Copy link
Contributor Author

currently being implemented by @papachap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants