Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plate element #262

Merged
merged 18 commits into from
Sep 9, 2024
Merged

add plate element #262

merged 18 commits into from
Sep 9, 2024

Conversation

obucklin
Copy link
Contributor

@obucklin obucklin commented Jun 28, 2024

This adds the plate element to Compas_timber. This is concieved as an extrusion with a boundary curve(Polyline) and a thickness. A vector input serves to switch the side towards which the plate is extruded. This has been tested with the Drill feature to ensure the Brep is oriented correctly and the boolean subtraction functions properly. Certain attributes are not yet implemented fully, such as the bounding box. TimberModel has been updated to include the TimberModel.plates property.

I will continue to change other modules to remove references to beam in exchange for more generic element types when appropriate.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

invokes don't seem to be working on mac, I will run these when I get back to my PC.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, added some comments on the code.
Two general question/requests:

src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/elements/plate.py Outdated Show resolved Hide resolved
src/compas_timber/model/model.py Show resolved Hide resolved
src/compas_timber/ghpython/components/CT_Plate/code.py Outdated Show resolved Hide resolved
@obucklin
Copy link
Contributor Author

obucklin commented Jul 2, 2024

I had not seen that. the two polygons as faces seems like a good way to do it. I will try it out and see how it works. My only concern is whether their shape (a mesh) works with the CT features. Maybe you know...

@obucklin obucklin requested review from chenkasirer and removed request for chenkasirer September 6, 2024 14:44
@property
def plates(self):
# type: () -> list[Plate]
return self._plates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._plates should be declared in TimberModel.__init__()

Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obucklin obucklin merged commit 857bf0d into main Sep 9, 2024
14 checks passed
@obucklin obucklin deleted the plate_element branch September 9, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants