-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plate element #262
add plate element #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, added some comments on the code.
Two general question/requests:
- please add unittests for the new
Plate
- have you had a look at https://github.com/BlockResearchGroup/compas_model/blob/main/src/compas_model/elements/plate.py? maybe it's not right for us but might be worth it to have a look.
I had not seen that. the two polygons as faces seems like a good way to do it. I will try it out and see how it works. My only concern is whether their shape (a mesh) works with the CT features. Maybe you know... |
@property | ||
def plates(self): | ||
# type: () -> list[Plate] | ||
return self._plates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._plates
should be declared in TimberModel.__init__()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds the plate element to Compas_timber. This is concieved as an extrusion with a boundary curve(Polyline) and a thickness. A vector input serves to switch the side towards which the plate is extruded. This has been tested with the Drill feature to ensure the Brep is oriented correctly and the boolean subtraction functions properly. Certain attributes are not yet implemented fully, such as the bounding box. TimberModel has been updated to include the
TimberModel.plates
property.I will continue to change other modules to remove references to
beam
in exchange for more genericelement
types when appropriate.What type of change is this?
Checklist
invokes don't seem to be working on mac, I will run these when I get back to my PC.
CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.