Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_surface_model_tolerance #266

Merged
merged 12 commits into from
Sep 9, 2024
Merged

Fix_surface_model_tolerance #266

merged 12 commits into from
Sep 9, 2024

Conversation

obucklin
Copy link
Contributor

Bug fix for SurfaceModels modeled in meters or otherwise very small. Made the relevant tolerances proportional to the outline length.

What type of change is this?

  • [ x] Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • [x ] I ran all tests on my computer and it's all green (i.e. invoke test).
  • [x ] I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@obucklin obucklin requested review from chenkasirer, jonashaldemann and papachap and removed request for jonashaldemann August 27, 2024 08:41
Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obucklin obucklin merged commit 264fb46 into main Sep 9, 2024
14 checks passed
@obucklin obucklin deleted the fix_surface_model_tolerance branch September 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants