-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix_surface_model_tolerance #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenkasirer
reviewed
Jul 17, 2024
chenkasirer
reviewed
Jul 17, 2024
chenkasirer
reviewed
Jul 17, 2024
chenkasirer
reviewed
Jul 17, 2024
chenkasirer
reviewed
Jul 17, 2024
obucklin
requested review from
chenkasirer,
jonashaldemann and
papachap
and removed request for
jonashaldemann
August 27, 2024 08:41
chenkasirer
reviewed
Sep 9, 2024
chenkasirer
reviewed
Sep 9, 2024
src/compas_timber/ghpython/components/CT_SurfaceModelJointOverride/icon.png
Outdated
Show resolved
Hide resolved
chenkasirer
reviewed
Sep 9, 2024
…aziokohler/compas_timber into fix_surface_model_tolerance
chenkasirer
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for
SurfaceModel
s modeled in meters or otherwise very small. Made the relevant tolerances proportional to the outline length.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas_timber.datastructures.Beam
.