Step joint notch feature #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papachap
requested review from
chenkasirer and
obucklin
and removed request for
obucklin
papachap
commented
Aug 6, 2024
|
@papachap would you say this is ready for review/merge? |
@chenkasirer I think you can now go for it! |
…into step_joint_notch_feature
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
reviewed
Oct 15, 2024
chenkasirer
reviewed
Oct 22, 2024
Comment on lines
+165
to
+176
| if step_shape == StepShapeType.DOUBLE: | ||
| if self.step_depth <= 0 or self.heel_depth <= 0: | ||
| raise ValueError("For a 'double' step_shape, both step_depth and heel_depth must be greater than 0.") | ||
| elif step_shape == StepShapeType.STEP: | ||
| if self.step_depth <= 0 or self.heel_depth != 0: | ||
| raise ValueError("For a 'step' step_shape, step_depth must be greater than 0 and heel_depth must be 0.") | ||
| elif step_shape in [StepShapeType.HEEL, StepShapeType.TAPERED_HEEL]: | ||
| if self.heel_depth <= 0 or self.step_depth != 0: | ||
| raise ValueError( | ||
| "For 'heel' or 'tapered heel' step_shape, heel_depth must be greater than 0 and step_depth must be 0." | ||
| ) | ||
| else: |
There was a problem hiding this comment.
I would actually not put this here.
validating it here means that, depending on the chronological order the parameters are set you might be validating parameters that haven't been set yet.
As by the end of __init__ all parameters should have already properly been set. that would be a good place to call a function which validates all these.
chenkasirer
reviewed
Oct 22, 2024
chenkasirer
reviewed
Oct 22, 2024
chenkasirer
reviewed
Oct 22, 2024
chenkasirer
reviewed
Oct 22, 2024
Co-authored-by: Chen Kasirer <chen902@gmail.com>
Co-authored-by: Chen Kasirer <chen902@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StepJointNotchbased on the example for theJackRafterCut.This is still a work in progress. The purpose of the pull request is to get an overall feedback on some of the decisions that I took and how parts of the code could be further optimized.
Also when possible, I would like to ask for some guidance on how to properly run tests of the code.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas_timber.datastructures.Beam.