Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfaceModelDefaultParams #285

Closed
wants to merge 8 commits into from
Closed

SurfaceModelDefaultParams #285

wants to merge 8 commits into from

Conversation

obucklin
Copy link
Contributor

@obucklin obucklin commented Sep 12, 2024

This adds default values for the SurfaceModel. stud_spacing = 625mm, beam_width = 60mm and frame_depth = 140mm`. These are scaled according to the Rhino Doc units, so please model in the correct inteded units.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@@ -18,19 +18,19 @@
{
"name": "stud_spacing",
"description": "spacing between studs.",
"typeHintID": "float",
"typeHintID": "none",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested and seems to work well.
Except: Why did you change the type hint? This causes an error message if I connect a Panel:
image
As long as it is set to "float", it recognizes an input from a Panel as a Number.

@obucklin obucklin closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants