Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Cut (birdsmouth) Feature and Joint #312

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

papachap
Copy link
Contributor

t-birdsmouth

This PR concerns the implementation of the DoubleCut BTLx Process following the new implementation system and the creation of a new Joint using the mentioned feature called TBirdsmouthJoint.

This is the first of a series of PR's that intent to update the already implemented features and joints to the new system.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas_timber.datastructures.Beam.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@papachap papachap assigned papachap and obucklin and unassigned papachap Oct 30, 2024
Copy link
Contributor

@chenkasirer chenkasirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments but otherwise lgtm

src/compas_timber/connections/t_birdsmouth.py Outdated Show resolved Hide resolved
tests/compas_timber/gh/test_double_cut.ghx Outdated Show resolved Hide resolved
src/compas_timber/_fabrication/double_cut.py Show resolved Hide resolved
src/compas_timber/_fabrication/double_cut.py Outdated Show resolved Hide resolved
@papachap papachap merged commit dd63b76 into gramaziokohler:main Oct 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants