Fix printing of Books #1770
Open
Fix printing of Books #1770
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in the original issue, PR#372 changed `GtkPrint` to try to parent its window via `self.uistate`, set in its constructor. In `DocReportDialog.make_document`, the `uistate` argument is passed to the format class, but `BookDialog` overrides that method and is missing that argument, causing the `GtkPrint.uistate` to remain `None`. This allows the 'Print...' option to work in plain Reports, but not Books. Fixes #12804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the original issue, PR#372 changed
GtkPrintto try to parent its window viaself.uistate, set in its constructor.In
DocReportDialog.make_document, theuistateargument is passed to the format class, butBookDialogoverrides that method and is missing that argument, causing theGtkPrint.uistateto remainNone. This allowed the 'Print...' option to work in plain Reports, but not Books.Fixes #12804